PointCloudLibrary/pcl
在 GitHub 查看Inconsistent handling of default seed in NormalGenerator & UniformGenerator
Open
#2,985 建立於 2019年4月9日
effort: lowgood first issuekind: todoneeds: feedback
倉庫指標
- Star
- (9,023 star)
- PR 合併指標
- (平均合併 8天 7小時) (30 天內合併 3 個 PR)
描述
As already discussed here default seed in random.h is not handled consistently.
One constructor of NormalGenerator has as default seed -1 during the other one (via Parameters) has 1 as default seed.
Furthermore you get currently following warning:
common/include/pcl/common/impl/random.hpp:49:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if(parameters_.seed != -1)
So we should discuss how to adjust code there.