PathOfBuildingCommunity/PathOfBuilding

An option for "DO NOT COMPARE WITH CLUSTER JEWELS"

Open

#6,275 建立於 2023年7月8日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Lua (5,224 star) (2,318 fork)batch import
enhancementgood first issue

描述

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

Currently, I have lots of jewels and try to find an upgrade I find an item or craft a custom one, and POB compares it with all jewels... But comparing it with existing cluster jewels makes no sense, and it should be hidden, or at least it should be an option, and by default, it should be set to FALSE

Describe the solution you'd like

Add an option to "Options" section that says,

  • Compare jewels with existing clusetr jewels - CHECKBOX, default unchecked

Describe alternatives you've considered

No response

Additional context

image

貢獻者指南

技術棧
lua
領域
desktoptooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Lua basicsPathOfBuilding UI understanding
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Check the jewel comparison logic in PathOfBuilding's source code. Look for existing options in the UI, such as checkboxes in the Options menu, to understand the pattern. The feature likely requires adding a new option flag and modifying the comparison function to skip cluster jewels when the flag is set. Examine files like 'src/Classes/Item.lua' or UI related scripts for comparison logic.