PathOfBuildingCommunity/PathOfBuilding

Add support for stages on certain vaal skills

Open

#5,698 建立於 2023年2月19日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Lua (5,224 star) (2,318 fork)batch import
enhancementgood first issue

描述

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

Vaal Blight, Vaal Reave and Vaal blade flurry are missing stages. image image image

Describe the solution you'd like

Them to have stage support

Describe alternatives you've considered

No response

Additional context

No response

貢獻者指南

技術棧
lua
領域
tooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of PathOfBuilding skill data structuresFamiliarity with Lua tables
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Examine how stages are implemented for similar Vaal skills (e.g., Vaal Ice Nova) in the skill gem data files. Look in the repository's Lua source for skill definitions. Add stage support for Vaal Blight, Vaal Reave, and Vaal Blade Flurry by modifying their data structures to include a 'stages' field, mirroring the pattern used for other skills. No linked PRs or comments provide additional guidance.