PathOfBuildingCommunity/PathOfBuilding

Dread and War banner are missing base flags

Open

#5,125 建立於 2022年10月2日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Lua (5,224 star) (2,318 fork)batch import
buggood first issue

描述

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

Them to have base flags which will allow them to have a duration shown.

What is the actual behaviour/value?

image image image image

How to reproduce the issue

No response

Character build code

https://pobb.in/U7tUNamjxz1Y

Screenshots

No response

貢獻者指南

技術棧
無
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic Lua knowledgefamiliarity with PoE skills
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the skill data files for Dread Banner and War Banner in the project's data directory, likely under src/Data/Skills/. Look for missing 'baseFlags' or similar fields that control duration display. The bug indicates these flags are absent, so adding them should enable the duration to show. Check similar skills for reference on how flags are defined, then test locally to confirm the fix.