PathOfBuildingCommunity/PathOfBuilding

Negative damage and duration

Open

#4,996 建立於 2022年8月27日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Lua (5,224 star) (2,318 fork)batch import
bug: calculationgood first issue

描述

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

You can't deal negative damage or duration so expected to see zero here.

The only notable stat is projectile speed which I think is capped at 1%.

What is the actual behaviour/value?

Some stats can become negative when they shouldn't e.g. damage or duration, regen, etc. image image image

How to reproduce the issue

Add alt quality defiance banner and ashes of the star and observe negative duration in panel. Add enfeeble with 500% curse effect and see negative damage on player.

This likely effect a bunch of other multipliers and should likely apply to all reduced and less multipliers capped to x 0. Except maybe some special cases.

Character build code

https://poe.ninja/pob/EgI

Screenshots

No response

貢獻者指南

技術棧
lua
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with Path of Exile mechanicsBasic knowledge of Lua
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate how reduced and less multipliers are applied in damage and duration calculations. Look for existing capping logic in the codebase, especially for stats like projectile speed. The issue indicates that reduced/less multipliers should be capped at zero except for special cases. Check files in 'src/Data/Stats' or 'src/Modules/Calc' for relevant functions.