The Minebot Will Not Show Any Installed Upgrades With Exception to Cooldown

Exploit Reports

• I confirm this issue is not an exploit. (Required)

BYOND Version

1620 BETA

Issue Description

The Nanotrasen Minebot will not display any other upgrades other than the Cooldown Upgrade at 0% capacity.

The upgrades, however, are applied, just not displayed.

What did you expect to happen?

To be able to see all of the upgrades currently installed (armor, melee, cooldown, ghost role).

What happened instead?

Was only able to see the Cooldown Upgrade, despite all upgrades being installed. See attached image.

Why is this bad/What are the consequences?

Bugs bad. Some miners will over-purchase upgrades, thinking the upgrade did not work.

Steps to reproduce the issue.

1. Have minebot.
2. Apply upgrade.
3. Examine to see if it shows up.
4. Apply another upgrade.
5. Examine to see if the upgrade is listed.

When did the problem start happening?

Round 38307 is when I finally looked at minebot.dm when trying to diagnose if the minebot was broken or not for another player. This issue, however, is likely a (minor) issue for the last several years.

Extra information

The last change to minebot.dm was almost a year ago. I, however, doubt that did anything since it was a whitespace cleanup PR.

So, likely a lot further back than that. This is likely something from pre-2019.

	. = ..()
	var/t_He = p_they(TRUE)
	var/t_him = p_them()
	var/t_s = p_s()
	if(health < maxHealth)
		if(health >= maxHealth * 0.5)
			. += "<span class='warning'>[t_He] look[t_s] slightly dented.</span>"
		else
			. += "<span class='boldwarning'>[t_He] look[t_s] severely dented!</span>"
	. += {"<span class='notice'>Using a mining scanner on [t_him] will instruct [t_him] to drop stored ore. <b>[max(0, LAZYLEN(contents) - 1)] Stored Ore</b>\n
	Field repairs can be done with a welder."}
	if(stored_gun && stored_gun.max_mod_capacity)
		. += "<b>[stored_gun.get_remaining_mod_capacity()]%</b> mod capacity remaining."
		for(var/A in stored_gun.get_modkits())
			var/obj/item/borg/upgrade/modkit/M = A
			. += "<span class='notice'>There is \a [M] installed, using <b>[M.cost]%</b> capacity.</span>"

This is the code for the minebot examine. There is zero other references for M.cost in the file. In theory, it shouldn't even be used, likely a holdover from the KPA code. I dunno.

This needs maybe some flags or something but I'm not a coder. Just wanted to bring this up and it should be a minor thing.

its 0240. I'm eepy.

Relevant log output/runtime error

No response