ParadiseSS13/Paradise

/obj/docking_port/mobile keeps a hard reference of the last_caller

Open

#19,295 建立於 2022年10月5日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)DM (445 star) (1,313 fork)batch import
GC RelatedGood First Issue

描述

Issue Description: The mobile docking ports keep a hard reference to the last caller. /datum/controller/subsystem/shuttle/proc/moveShuttle is the proc which sets it.

[2022-10-05T20:51:06] Found /mob/dead/observer [0x300003b] in /obj/docking_port/mobile's [0x200057f] last_caller var. World -> /obj/docking_port/mobile

Steps to reproduce the problem:

  1. Spawn as a ghost or aghost.
  2. Use any shuttle console and call/send the shuttle
  3. Become a mob or something else to delete the ghost

When did the problem start happening: For a while. I have introduced it 2 years ago in #13208 :(

Extra information: It should use a UID here instead. This should be a relatively easy first GC issue.

貢獻者指南

技術棧
無
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic DM languageUnderstanding of garbage collection
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The bug is in /datum/controller/subsystem/shuttle/proc/moveShuttle which sets last caller. The fix is to use a UID instead of a hard reference. Check PR #13208 where it was introduced. Implement a UID system for the docking port and modify the variable to store the UID.