ParadiseSS13/Paradise

/obj/docking_port/mobile keeps a hard reference of the last_caller

開放

#19,295 建立於 2022年10月5日

 (0 則留言) (0 個反應) (0 位負責人)DM (1,313 個分叉)batch import
GC RelatedGood First Issue

倉庫指標

星標
 (445 顆星)
PR 合併指標
 (平均合併 13天 5小時) (30 天內合併 90 個 PR)

描述

Issue Description: The mobile docking ports keep a hard reference to the last caller. /datum/controller/subsystem/shuttle/proc/moveShuttle is the proc which sets it.

[2022-10-05T20:51:06] Found /mob/dead/observer [0x300003b] in /obj/docking_port/mobile's [0x200057f] last_caller var. World -> /obj/docking_port/mobile

Steps to reproduce the problem:

  1. Spawn as a ghost or aghost.
  2. Use any shuttle console and call/send the shuttle
  3. Become a mob or something else to delete the ghost

When did the problem start happening: For a while. I have introduced it 2 years ago in #13208 :(

Extra information: It should use a UID here instead. This should be a relatively easy first GC issue.

貢獻者指南