ParadiseSS13/Paradise

Infrared lasers work even in a backpack/locker/etc

Open

#15,958 建立於 2021年4月28日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)DM (445 star) (1,313 fork)batch import
BugGood First Issue

描述

Issue Description:

Tripwire laser mines (chem grenades using infrared as detonator) will check in the direction they're set even if they are in a container. Logically, the laser shouldnt pierce through?

What did you expect to happen:

Nothing.

What happened instead:

Tripwire is triggered by somebody walking in front of a locked locker.

Why is this bad/What are the consequences:

Makes it much easier to hide tripwire mines. Not logical.

Steps to reproduce the problem:

  1. Make a tripwire mine chem grenade
  2. Set it to activated, with any direction or invisibility setting
  3. Walk in front of it in the direction set, boom

When did the problem start happening:

Likely long living oversight

貢獻者指南

技術棧
無
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of SS13 object hierarchyBasic knowledge of DM scripting
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Examine the infrared detonator code, likely in `code/game/objects/items/grenades/infrared.dm` or similar. Look for the laser scanning logic that checks line of sight. The fix should add a condition to verify that the mine is not inside a container (e.g., backpack, locker) before triggering. Check the `loc` variable to determine if the item is inside another atom. Reference the issue comments for any additional context.
Infrared lasers work even in a backpack/locker/etc · ParadiseSS13/Paradise#15958 | Good First Issue