POSYDON-code/POSYDON

Clean out duplicated functions and variables

已關閉

#442 建立於 2024年11月21日

 (0 則留言) (0 個反應) (0 位負責人)Python (35 個分叉)auto 404
enhancementgood first issuev2 feature

倉庫指標

星標
 (42 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

We have different functions and variables which have duplicates. We should clean that up to always use one version. Here some examples

  • posydon.utils.gridutils.kepler3_a vs. posydon.utils.common_functions.orbital_separation_from_period
  • posydon.utils.gridutils.T_merger_P vs. posydon.utils.common_functions.inspiral_timescale_from_orbital_period
  • posydon.utils.gridutils.T_merger_a vs. posydon.utils.common_functions.inspiral_timescale_from_separation
  • variables are often hard coded in functions instead of imported from where they are defined, this happens often in step_* vs. flow_chart

貢獻者指南