Prevent proposals with duplicate actions from being submitted in `GovernorTimelockCompound` · OpenZeppelin/openzeppelin-contracts#6431

(3 留言) (0 反應) (1 負責人)JavaScript (23,941 star) (11,560 fork)batch import

good first issue

描述

It is a know issue in Compound Governance that proposal queueing will fail if it contains 2 (or more) actions that have the same target, value, and calldata. While this can be circumvented by adding extra (useless) bytes at the end of the calldata to create unicity, it is possible to create such a proposal and not realised if will never be executable after the voting ends.

We should modify the behavior of _propose in GovernorTimelockCompound to reject proposals that have duplicated actions

貢獻者指南

技術棧: 無
領域: blockchainsecurity
議題類型: feature
難度: 3
預計時間: half day
活動狀態: blocked
清晰度: clear
前置要求: Solidity basicsOpenZeppelin ContractsCompound governance pattern
新手友善度: 30
研究方向: Examine the GovernorTimelockCompound contract (likely in contracts/governance/extensions/GovernorTimelockCompound.sol). The propose function should be modified to check for duplicate actions before adding them. Duplicate actions are defined as having the same target, value, and calldata. Consult the OpenZeppelin governance documentation and existing tests for guidance.