OpenZeppelin/openzeppelin-contracts

Consider adding an ESLint rule for no async in describe blocks

已關閉

#4,943 建立於 2024年3月6日

 (6 則留言) (0 個反應) (0 位負責人)JavaScript (11,560 個分叉)batch import
good first issuetests

倉庫指標

星標
 (23,941 顆星)
PR 合併指標
 (平均合併 42天 15小時) (30 天內合併 16 個 PR)

描述

From @fvictorio:

I forgot to mention:

  • The wrong async keywords in describe functions can be prevented with this rule.
  • The missing await keywords are harder. Ideally you'd use typescript and the no-floating-promises rule, but I understand that that would be a huge undertaking.

Originally posted by @fvictorio in https://github.com/OpenZeppelin/openzeppelin-contracts/issues/4942#issuecomment-1980874051

We're considering adding only the ESLint rule and not migrating to Typescript to catch floating promises. However, we're open to alternatives.

貢獻者指南