NuGet/Home

Refactor UIActionEngineTests that use packagesFolder to avoid looking at the drive root

Open

#12,556 建立於 2023年4月24日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)HTML (1,459 star) (292 fork)batch import
Category:Quality WeekFunctionality:VisualStudioUIPriority:2Type:Testgood first issue

描述

@"\packagesFolder" seems like a bad idea. A single leading '' usually means "from the root of the drive" on Windows. A temporary directory or a local directory (@".\packgesFolder") seems better.

https://github.com/NuGet/NuGet.Client/pull/5109/files#r1175482193

貢獻者指南

技術棧
csharp
領域
testing
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C# basicsunit testingNuGet client tests
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
The issue is to refactor UIActionEngineTests that use a hardcoded path '\packagesFolder' to a temporary directory, as suggested in PR #5109. Look at the test file UIActionEngineTests (likely in the NuGet.Client repo) and replace occurrences of @"\packagesFolder" with a path like Path.Combine(Path.GetTempPath(), "packagesFolder") or use a test temp directory. Ensure the change is consistent with similar test patterns.