NuGet/Home

Be smarter about PackagePath and Pack metadata values

已關閉

#10,830 建立於 2021年5月5日

 (3 則留言) (1 個反應) (0 位負責人)HTML (292 個分叉)batch import
Functionality:PackIcebox cleanup candidatePriority:3Status:InactiveType:DCRhelp wanted

倉庫指標

星標
 (1,459 顆星)
PR 合併指標
 (平均合併 464天 23小時) (30 天內合併 1 個 PR)

描述

See the documentation on adding package readme support, it states you need to add:

<PropertyGroup>
    ...
    <PackageReadmeFile>readme.md</PackageReadmeFile>
    ...
</PropertyGroup>

<ItemGroup>
    ...
    <None Include="docs\readme.md" Pack="true" PackagePath="\"/>
    ...
</ItemGroup>

Now, the PackagePath metadata is a packing-specific metadata item that is not used anywhere else (AFAIK). It seems quite obvious that if I specify a PackagePath metadata, it's because I want the item packed. Specifying also Pack=true seems entirely unnecessary and redundant.

So, the proposal is:

Whenever PackagePath is specified in any item (of the supported candidates), asume Pack=true for the item.

(this is what nugetizer does too, btw, it's more natural and less surprises).

貢獻者指南