What does the Change Emails "With Issues" option mean under notification settings? · Netflix/security_monkey#945

(2 留言) (0 反應) (0 負責人)Python (4,341 star) (832 fork)batch import

bughelp wanted

描述

Under notification settings, I set Change Emails to be "With Issues" and set EMAIL_AUDIT_REPORTS_INCLUDE_JUSTIFIED=False in the config. I assumed this meant it would only email me on changes with unjustified issues, however I still get emails for changes that have no issues at all (e.g. creating / deleting RDS snapshots, updating route 53 records, etc.). Is this a bug or am I not understanding what "With issues" means? Also, I am using the code in the develop branch fetched 2-14.

Thanks!

貢獻者指南

技術棧: pythonaws
領域: securitybackend
議題類型: bug
難度: 3
預計時間: 1-3 hours
活動狀態: stale
清晰度: mostly clear
前置要求: Basic PythonSecurity Monkey notification settings
新手友善度: 40
研究方向: Investigate the notification settings logic in the Security Monkey codebase, particularly around the 'With Issues' option and the EMAIL AUDIT REPORTS INCLUDE JUSTIFIED configuration. Look at the source files for email notifications (e.g., `security monkey/notification utils.py` or similar) to understand the condition used to filter changes. Check the two comments on the issue for any additional details or hints. Identify whether the logic correctly excludes changes without issues or if there is a bug that sends emails for all changes regardless.