NativeScript/NativeScript

Bug(iOS): Escape-gesture doesn't work as expected for VoiceOver users.

Open

#6,123 建立於 2018年7月26日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)TypeScript (23,592 star) (1,634 fork)batch import
featurehelp wantedos: ios

描述

Tell us about the problem

Accessibility users can't dismiss dialogs and go back with the z-gesture*.

*) Z-Gesture also known as the escape-gesture

Which platform(s) does your issue occur on?

iOS only.

Please provide the following version numbers that your issue occurs with:

  • CLI: 4.1.x, 4.0.x, 3,x etc.
  • Cross-platform modules: 4.1.0
  • Runtime(s): tns-ios@4.1.0
  • Plugin(s): none

Please tell us how to recreate the issue in as much detail as possible.

The problem is in two parts, both requires VoiceOver to be enabled to demonstrate.

Dialogs

Any dialog created from tns-core-modules/ui/dialogs cannot be dismissed with the z/escape-gesture. NativeScript doesn't implement the accessibiliityPerformEscape()-function on UIAlertController.

Modal pages without a NavigationButton.

Create a new page and hide the NavigationButton. This disables the z-gesture for this page.

Our accessibility users expects the z-gesture working in both these cases.

Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

I've create a simple example here: https://play.nativescript.org/?template=play-ng&id=vuchBL&v=10

You need to enable VoiceOver to see the problem.

  1. Start by tapping "Show Alert", this will create an alert. Try to dismiss it by drawing a Z on the screen with two fingers. The device will make a noise but nothing else will happen. Our accessibility users expects the alert to be dismissed and complains about it.

  2. Close the alert manually.

  3. Tap the "Show modal page without the NavigationButton" This page will not have the NavigationButton to the left but will have a "done"-button to the right. (This is a common design for settings pages in our app). Once again try to dismiss the page with the z-gesture. This won't work.

  4. Go back to the home component again.

  5. Now tap the last button: "Show modal page with the NavigationButton" This is the same page as before, but with the NavigationButton. Once again try to dismiss the page with the z-gesture. This time you end up on the previous page, as expected.

I've previous submitted #4349 but back when I didn't understand the cause and ended up closing the issue, because it looked like an error in our end.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

貢獻者指南

技術棧
typescriptios
領域
accessibilitymobile
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic iOS accessibility knowledgeFamiliarity with NativeScript UI dialogs
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue requires implementing the escape gesture (two finger Z gesture) for VoiceOver users in two scenarios: UIAlertController dialogs and modal pages without NavigationButton. The fix involves overriding the accessibilityPerformEscape() method on UIAlertController and ensuring that modal pages without NavigationButton also handle the escape gesture. Relevant files are likely in the dialogs module and the modal page controller. See previous related issue #4349 for context.
Bug(iOS): Escape-gesture doesn't work as expected for VoiceOver users. · NativeScript/NativeScript#6123 | Good First Issue