MrSwitch/hello.js

Support on auth.error event

Open

#541 建立於 2018年2月17日

在 GitHub 查看
 (14 留言) (0 反應) (1 負責人)JavaScript (4,630 star) (557 fork)batch import
good first issuehelp wanted

描述

On page redirect authentication login is captured. However errors are not.

e.g. stored in localstorage would be...

{
	"adB2CSignInSignUp": {
		"error": {
			"code": "access_denied",
			"message": "AADB2C90118:+The+user+has+forgotten+their+password.\r\nCorrelation+ID:+3f341530-ed9a-4546-a646-2e2ac3e3b43d\r\nTimestamp:+2017-07-25+19:29:24Z\r\n"
		},
		"error_description": "AADB2C90118:+The+user+has+forgotten+their+password.\r\nCorrelation+ID:+3f341530-ed9a-4546-a646-2e2ac3e3b43d\r\nTimestamp:+2017-07-25+19:29:24Z\r\n",
		"state": "",
		"client_id": "da7caa3a-739c-436c-a32b-b428d3e8c043",
		"network": "adB2CSignInSignUp",
		"display": "page",
		"redirect_uri": "https://localhost:44369/redirect",
		"scope": "openid,https://foobar.onmicrosoft.com/foobarapi/use",
		"page_uri": "https://localhost:44369"
	}
}

This should trigger any listeners on auth.error on page load.

貢獻者指南

技術棧
javascriptrest api
領域
authentication
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptevent handling
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
Investigate the existing event system in hello.js, specifically how `auth.login` and other events are triggered. Look at source files for the event emitter pattern. Review the issue comments for any proposed implementation details. No linked PR exists.
Support on auth.error event · MrSwitch/hello.js#541 | Good First Issue