Miserlou/Zappa

undeploy didn't nuke my apigw custom domain

Open

#698 建立於 2017年3月1日

在 GitHub 查看
 (7 留言) (0 反應) (0 負責人)Python (11,903 star) (1,286 fork)batch import
bughacktoberfesthelp wanted

描述

Context

I did a 'zappa undeploy production' for a project with a 'domain' set under 'production'.

Expected Behavior

I expected that to correctly remove the apigw entries that it created.

Actual Behavior

It removed the API-GW API, but not the 'Custom Domain Name' that it was using. The custom domain was 'emptied', however, in that it no longer listed any API Mappings, but I can't tell if that was Zappa doing its job or AWS nuking a reference to a no-longer-existing API entry.

Possible Fix

Your Environment

  • zappa --version => 0.37.1
  • linux (ubuntu 16.04)
  • python -V => 2.7.12

貢獻者指南

技術棧
pythonawsrest api
領域
devopscloud
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
AWSPythonZappa
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue involves the Zappa undeploy command not removing the API Gateway custom domain. To fix, examine the undeploy logic in the Zappa source code (likely in `zappa/cli.py` or `zappa/deploy.py`). Look for the part that deletes the API and ensure a similar deletion step for the custom domain using the AWS API. Also review the issue comments (#698) for any guidance or attempted solutions.