Miserlou/Zappa

Check Config Files for Allowed Values

Open

#1,165 建立於 2017年10月11日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Python (11,903 star) (1,286 fork)batch import
hacktoberfesthelp wanted

描述

Context

Was not seeing my remote environment variables because my config value was "remote_evn". Mistake on my part, but it would be nice if zappa checked config files to ensure that values being set were even values used by zappa.

Expected Behavior

When a user gives a config value not used by Zappa, it tells the user and suggests that it might be a typo. Just lowers the learning curve slightly and improves QOL.

Actual Behavior

Users are allowed to wallow in their mistakes

Possible Fix

Keep a white list of config keys and test against those.

貢獻者指南

技術棧
python
領域
backenddevops
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
PythonZappa config knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue suggests adding a whitelist of valid config keys in Zappa's configuration validation. Look at files like 'zappa/cli.py' or 'zappa/settings.py' where config parsing occurs. The maintainers have not provided additional guidance; the proposed fix is to maintain a set of allowed keys and check against user provided keys, emitting a warning or error for unknown keys.
Check Config Files for Allowed Values · Miserlou/Zappa#1165 | Good First Issue