Midburn/spark

Clean global scope in all controllers.

開放

#980 建立於 2018年11月29日

 (1 則留言) (0 個反應) (1 位負責人)JavaScript (44 個分叉)auto 404
Cleanupgood first issue

倉庫指標

星標
 (18 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

Overview of the problem

We have several functions declared globally in controller files. This can create issues hard to anticipate and solve.

Description

  1. We need to move all functions into scope. image image
  2. We need to make sure the functions aren't used in any other file (if so, we should create an AngularJS service to be shared between the controllers)
  3. Sanity after the cleanup - check most screens and buttons don't raise exceptions related to missing functions.

Expected behavior

Functions should be scoped

Actual behavior

Functions are declared outside of AngularJS's controllers call back

貢獻者指南