Microsoft/vscode

Parameter hints should not use aria.alert

Open

#90,874 建立於 2020年2月18日

在 GitHub 查看
 (7 留言) (1 反應) (2 負責人)TypeScript (10,221 fork)batch import
accessibilitydebteditor-parameter-hintshelp wanted

倉庫指標

Star
 (74,848 star)
PR 合併指標
 (平均合併 11小時 43分鐘) (30 天內合併 1,000 個 PR)

描述

Instead they should use activeDescendent same as suggest widget. Code pointer where parameterHints are currently using aria alert https://github.com/microsoft/vscode/blob/8451f8bd913914aac17b6b3273b6ed0db137a217/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts#L251

As @pawelurbanski points out: Using activeDescendant for parameter hints.

  • Currently, the hints are outputted by the alert function, which has 2 nasty attributes:
  • If you do not modify the message with a counter, repeate messages are filtered out,
  • If you modify the message you go crazy after hearing: string appeared 29 times,
  • When there is more than 1 paremter all the items are read as a single string with no pauses,
  • The alert is an offscreen DOM element that is not-focusable so you can’t scroll through the items.
  • I just disable the hints all together and use Ctrl+Shift+Space every now and then…

fyi @alexdima

貢獻者指南