Microsoft/vscode

Incorrect scaling of native file picker

Open

#85,898 建立於 2019年12月1日

在 GitHub 查看
 (25 留言) (3 反應) (1 負責人)TypeScript (74,848 star) (10,221 fork)batch import
bugconfirmedelectronhelp wantedupstreamupstream-issue-linkedwindowsworkbench-os-integration

描述

VS Code Version Version: 1.40.2 (user setup) Commit: f359dd69833dd8800b54d458f6d37ab7c78df520 Date: 2019-11-25T14:54:45.096Z Electron: 6.1.5 Chrome: 76.0.3809.146 Node.js: 12.4.0 V8: 7.6.303.31-electron.0 OS: Windows_NT x64 10.0.19033

Steps to Reproduce: Using a 4k display (mine is an XPS 15 7590 with OLED screen with 1080p extra monitor. This could be a windows problem, but I am not seeing it happen on other apps. Closest I have seen is when using Windows Explorer there is an awkward transition between 4k screen and normal screen.

Also notice VS Code is not correctly showing on non-4k screen. See image 4 below. The bottom of vs code is under taskbar. Changing task bar to top also doesn't seem to fit properly.

  1. File > Open Folder
  2. Open Folder Modal is really large on 1080p screen, but normal on 4k screen.

Screenshots

4k Screen img_1 4k Open Modal window img_2 1080p Modal window dragged over img_3_1080screen 1080p VS Code open modal on 1080 screen img_4_1080screen Windows Version img_5

Does this issue occur when all extensions are disabled?: Yes/No Yes

貢獻者指南

技術棧
typescriptjavascriptelectron
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Node.jsElectron basicsWindows DPI scaling understanding
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the Electron native file dialog API used by VS Code (likely in src/vs/platform/dialogs/electron main/dialogServiceImpl.ts). Reproduce the scaling issue on Windows with multiple monitors at different DPI. Check if the issue is in Electron's dialog scaling or VS Code's dialog wrapper. Review previous comments for any suggested fixes or workarounds.