Microsoft/vscode

Incorrect keyboard shortcut shown in menu.

Open

#85,798 建立於 2019年11月29日

在 GitHub 查看
 (6 留言) (0 反應) (1 負責人)TypeScript (74,848 star) (10,221 fork)batch import
bugchromiumconfirmedhelp wantedlinuxmenusupstream

描述

  • VSCode Version: 1.40.2 (also happens in 1.41.0-insider)
  • OS Version: Pop!_OS 19.10 64-bit (which is very much like Ubuntu 19.10 Eoan Ermine)

Steps to Reproduce:

  1. Press Ctrl+K, Ctrl+S to open the keyboard shortcut editor;
  2. Find the entry for toggling the Activity Bar (workbench.action.toggleActivityBarVisibility)
  3. Set its keybinding to "Ctrl + Super + A", which shouldn't be used by anything else by default; "Super" is the "Windows" key on PC keyboards, also known as the meta key in Linux.
  4. Close the keyboard shortcut editor;
  5. Open the "View" menu --> "Appearance"
  6. See that the keyboard shortcut displayed next to "Show Activity Bar" is "Ctrl+A" instead of "Ctrl+Super+A"

Does this issue occur when all extensions are disabled?: Yes

貢獻者指南

技術棧
typescriptjavascriptelectron
領域
frontenddesktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic TypeScriptVSCode keybinding APIElectron menu systemLarge codebase navigation
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the menu rendering code in VSCode's workbench, specifically the part that displays keyboard shortcuts next to menu items. The issue relates to the command 'workbench.action.toggleActivityBarVisibility'. Look at files like 'src/vs/workbench/services/keybinding/browser/keybindingServiceImpl.ts' or the menu widget. Ensure that when a keybinding is customized, the menu displays the correct shortcut. Check if there is a discrepancy between the stored keybinding and the displayed one in the menu's label.