Microsoft/vscode

[scss] selector specificity works wrong with nested selectors

Open

#63,200 建立於 2018年11月15日

在 GitHub 查看
 (3 留言) (10 反應) (1 負責人)TypeScript (74,848 star) (10,221 fork)batch import
bugcss-less-scsshelp wanted

描述

Issue Type: Bug

Css specifity calculator doesn't respect nested selectors or selectors with &.

#id {} /* (1, 0, 0) */

#id div {} /* (1, 0, 1) */

#id {
  div { /* (0, 0, 1) */
  }
}

.block{ /* (0, 1, 0) */
  &__element { /* (0, 0, 0) */
  }
}

Reproduced without any extensions

VS Code version: Code 1.29.0 (5f24c93878bd4bc645a4a17c620e2487b11005f9, 2018-11-12T07:47:15.448Z) OS version: Windows_NT x64 10.0.17134

貢獻者指南

技術棧
csstypescript
領域
developer experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
CSS specificity rulesSCSS nesting syntax
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Investigate the CSS specificity calculation in the VS Code CSS language service, likely in the `extensions/css language features/server` directory. The bug is that nested selectors and `&` in SCSS are not being expanded correctly before specificity calculation. Look at the parser and selector specificity logic to understand how nested rules are handled. Since the issue is old and has an assignee but no linked PR, check the assignee's activity and consider fixing the expansion of nested selectors before computing specificity.