Microsoft/vscode

[Emmet] Include should be more like DocumentSelector

Open

#49,588 建立於 2018年5月10日

在 GitHub 查看
 (11 留言) (0 反應) (1 負責人)TypeScript (74,848 star) (10,221 fork)batch import
emmetfeature-requesthelp wanted

描述

Currently, the Emmet extension has a setting called emmet.includeLanguages which just targets language IDs to map to the Emmet-capable language ID. I think it would be very useful if instead you could use something more like DocumentSelector, which also allows DocumentFilter instead of just language ID.

貢獻者指南

技術棧
typescript
領域
developer experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
VSCode extension APIEmmet extension internals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
This issue is assigned to a maintainer. The change requires modifying the `emmet.includeLanguages` setting in `extensions/emmet/package.json` and the corresponding activation logic in `extensions/emmet/src/` to support `DocumentSelector` objects. Review the VSCode API documentation for `DocumentFilter` and `DocumentSelector` to understand the new structure. The existing comments provide some discussion on possible approaches. Ensure backward compatibility with the current string only format.
[Emmet] Include should be more like DocumentSelector · Microsoft/vscode#49588 | Good First Issue