Microsoft/vscode

code serve web --server-base-path PWA app does not include base path

Open

#209,601 建立於 2024年4月5日

在 GitHub 查看
 (4 留言) (1 反應) (1 負責人)TypeScript (74,848 star) (10,221 fork)batch import
bughelp wantedremote

描述

When we run vscode as code serve-web with the new option server-base-path, then PWA app doesn't work properly because it doesn't use the path(tested in chrome and edge).

貢獻者指南

技術棧
typescriptnodejs
領域
frontendbackend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
needs investigation
前置要求
familiarity with VSCode's code serve web featurebasic understanding of progressive web apps
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue reports that when using `code serve web server base path`, the PWA app does not include the base path. To fix, examine how the PWA service worker is registered in the web server variant. Look at files in `src/vs/server/` and the web shell. Ensure the base path is injected into the service worker registration URL. Check comments in the issue for any specific reproduction steps or maintainer guidance.
code serve web --server-base-path PWA app does not include base path · Microsoft/vscode#209601 | Good First Issue