Microsoft/vscode

Don't prompt for user confirmation when workspace typescript.tsserver.nodePath is set to "node"

Open

#200,923 建立於 2023年12月15日

在 GitHub 查看
 (5 留言) (1 反應) (1 負責人)TypeScript (10,221 fork)batch import
feature-requesthelp wantedtypescript

倉庫指標

Star
 (74,848 star)
PR 合併指標
 (平均合併 11小時 43分鐘) (30 天內合併 1,000 個 PR)

描述

We had this awesome feature merged #191019. This will allow our team to get off the custom tsserver implementation we have been using and just use this new setting for everyone.

One issue is that right now when we have a workspace setting for "typescript.tsserver.nodePath" set to "node" (i.e. auto-detect node installation) we get a prompt as shown below

image

I would argue that if the setting is "node" then we are using a user-installed nodejs installation and we don't need to ask for this prompt, because it's user installed and if there are security risks then user has already accepted them with the nodejs installation.

Happy to create a PR to update this if someone can confirm that it's Ok to make this change.

貢獻者指南