Microsoft/vscode

Custom editors should not allow to make edits after extension host restart

Open

#184,142 建立於 2023年6月2日

在 GitHub 查看
 (2 留言) (1 反應) (1 負責人)TypeScript (10,221 fork)batch import
bugcustom-editorshelp wanted

倉庫指標

Star
 (74,848 star)
PR 合併指標
 (平均合併 11小時 43分鐘) (30 天內合併 1,000 個 PR)

描述

This is a follow up from https://github.com/microsoft/vscode/issues/180514

When the EH restarts with an opened custom editor, that editor continues to be editable but does not report any dirty indication and does not allow to be saved because the old EH it was talking to is gone.

Recording 2023-06-02 at 10 50 46

I think a custom editor should detect that it lost the connection to its extension on the EH side and then do something, such as:

  • turn readonly to prevent further edits
  • show an indication to the user what happened

//cc @Tyriar

貢獻者指南