Microsoft/vscode

Git - Removing a folder from multi-root workspace does not remove repo

Open

#108,757 建立於 2020年10月15日

在 GitHub 查看
 (14 留言) (3 反應) (1 負責人)TypeScript (74,848 star) (10,221 fork)batch import
buggitgood first issuehelp wantedteam-low-hanging

描述

Version: 1.50.1 (user setup) Commit: d2e414d9e4239a252d1ab117bd7067f125afd80a Date: 2020-10-13T15:06:15.712Z Electron: 9.2.1 Chrome: 83.0.4103.122 Node.js: 12.14.1 V8: 8.3.110.13-electron.0 OS: Windows_NT x64 10.0.19041

Steps to Reproduce:

  1. Create a multi-root workspace:

    • folder_A contains git-repo A
    • folder_B contains git-repo B

    SCM pane shows repo A and repo B

  2. Remove folder_B from workspace

    SCM pane still shows repo B (expected: repo B is automatically closed/removed)

  3. Select "close repo" on repo B

    repo B vanishes from SCM pane

  4. reopen workspace

    SCM pane again shows repo B (expected: repo B does no longer show up)

Workaround: Delete workspace settings under C:\Users\<username>\AppData\Roaming\Code\User\workspaceStorage.

Does this issue occur when all extensions are disabled?: Yes/No

貢獻者指南

技術棧
typescript
領域
frontenddeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
VSCode source code navigationTypeScriptGit SCM extensionworkspace storage model
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the SCM view model and workspace storage logic in vscode. The bug likely lies in how the Git extension tracks repositories from workspace folders. Focus on the `git` extension's `repository` model and the workspace's folder removal event handling. Refer to comments in the issue for discussion on potential fixes.