Microsoft/monaco-editor

[Bug] Many duplicates in minified tsWorker.js leading to large file

Open

#4,184 建立於 2023年9月22日

在 GitHub 查看
 (3 留言) (1 反應) (0 負責人)JavaScript (14,836 star) (1,283 fork)batch import
debthelp wanted

描述

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Reproduction Steps

  1. Open a compiled version of the file min/vs/language/typescript/tsWorker.min.js CDN Example
  2. Optionally copy the code in a VS Code window
  3. Search for interface CanvasDrawPath {
  4. Note that the definition is found twice
  5. This duplication issue is the case for a lot of code

Code20230923 - 0129

Actual (Problematic) Behavior

The minified version of tsWorker.js is around 4.6 MB I want to use the Monaco editor in a web extension, but this allows a maximum file size of 4 MB

If the code duplication is fixed, that would reduce the filesize enough to get below 4 MB

Expected Behavior

No duplicate code generated during the build

Additional Context

Related Add_ons Linter issue https://github.com/mozilla/addons-linter/issues/3915

貢獻者指南

技術棧
typescriptjavascript
領域
performancebuild system
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of build tools (webpack)Familiarity with minification
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Examine the build configuration for tsWorker, likely in webpack config. Investigate how TypeScript lib declarations are bundled and minified, possibly causing duplication. Check if there's a deduplication plugin or if the build process can be adjusted to avoid including duplicate declarations. Refer to the related addons linter issue for context.