Improve Go syntax highlighting · Microsoft/monaco-editor#1770

(0 留言) (0 反應) (0 負責人)JavaScript (14,836 star) (1,283 fork)batch import

feature-requestgrammarshelp wantedopen for PR

描述

monaco-editor version: 0.19.3 Browser: Chrome 79 maybe OS: macOS Mojave Playground code that reproduces the issue:

monaco.editor.create(document.getElementById("container"), {
	value: 'fmt.Println("666")',
	language: "go"
});

How Monaco/Monarch highlights things:

How VSCode highlights things:

Also in VSCode (latest, not Insiders) that line of code is highlighted differently once rendered from Markdown, I think it's ok to expect some differences since my editor has a dark background and the rendered Markdown has a light background, but here a method's name is no longer of a different color as far as I can see, and that seems a bit too much of a difference:

貢獻者指南

技術棧: gojavascripttypescript
領域: frontenddeveloper experience
議題類型: bug
難度: 3
預計時間: 1-3 hours
活動狀態: stale
清晰度: clear
前置要求: Familiarity with Go syntaxUnderstanding of Monarch tokenizerBasic JavaScript/TypeScript
新手友善度: 65
研究方向: Examine the Go language definition file (likely src/basic languages/go/go.ts) to compare the tokenizer rules with VSCode's Go highlighting. Identify the rules that produce incorrect colors for string literals and method names. Adjust the Monarch tokenizer rules to match VSCode's output, ensuring string literals are colored correctly and method names are distinguished from regular function calls. Test the changes locally using the Monaco editor development environment.