Microsoft/monaco-editor

Make monaco-editor-samples have independent folders

Open

#1,761 建立於 2020年1月10日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (14,836 star) (1,283 fork)batch import
documentationfeature-requesthelp wanted

描述

Please include /node_modules/ in .gitignore for the samples that have a .gitignore file, as appropriate.

After I copy the sample into my own repository and run yarn install, if I didn't check before running git add ., I would have added everything under node_modules/.

貢獻者指南

技術棧
javascriptnodejs
領域
developer experiencetooling
議題類型
chore
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic knowledge of Node.js projects
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
Locate sample folders in the repository (e.g., under 'samples/'). For each sample folder that contains a .gitignore file, add a line '/node modules/' to ignore the node modules directory. If a sample folder does not have a .gitignore, consider whether one should be created. This change ensures that users copying the samples do not accidentally commit node modules. The issue is straightforward and requires no additional dependencies.
Make monaco-editor-samples have independent folders · Microsoft/monaco-editor#1761 | Good First Issue