Microsoft/monaco-editor

sample electron-amd/electron-index.html have problem with path including special characters, such as #

Open

#1,718 建立於 2018年5月29日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (14,836 star) (1,283 fork)batch import
documentationfeature-requesthelp wantedopen for PR

描述

electron-amd/electron-index.html declares a function named uriFromPath to handle file paths, but it seems that if a file path has # or other special characters in it, the amdRequire won't work.

https://github.com/Microsoft/monaco-editor-samples/blob/779a88524d1755ad087420ce459b37199bf4df0e/electron-amd/electron-index.html#L28-L34

貢獻者指南

技術棧
javascripthtml
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic JavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
The issue is in the `uriFromPath` function in `electron amd/electron index.html`. The function does not encode special characters like `#` in file paths, causing `amdRequire` to fail. The fix likely involves using `encodeURIComponent` or a similar method to escape special characters. See the linked line: https://github.com/Microsoft/monaco editor samples/blob/779a88524d1755ad087420ce459b37199bf4df0e/electron amd/electron index.html#L28 L34.