Microsoft/monaco-editor

Prevent formatDocument to steal focus

Open

#1,245 建立於 2018年12月22日

在 GitHub 查看
 (2 留言) (1 反應) (0 負責人)JavaScript (14,836 star) (1,283 fork)batch import
feature-requesthelp wantedopen for PR

描述

monaco-editor version: 0.15.6 Browser: chrome OS: linux

I use this.editor.getAction('editor.action.formatDocument').run() to format a document. This works, but it also set's the focus to the the editor. Is that intended behaviour? Is there a way to disable the change of focus?

貢獻者指南

技術棧
javascripttypescript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic understanding of Monaco Editor API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
The issue reports that calling `editor.getAction('editor.action.formatDocument').run()` steals focus to the editor. The fix likely involves ensuring that formatting does not change focus. Start by examining the Monaco Editor source code in `vs/editor/contrib/format/formatActions.ts` or similar files to see how the format action is implemented and where focus is set. Check the `run()` method of the action to identify if focus is explicitly set. Consider passing an option to suppress focus change or modifying the action to not focus conditionally. Look at related issues or PRs in the repository for similar focus related fixes.