Microsoft/monaco-editor

F# highlighting issues with block comments tokenized by strings

Open

#1,240 建立於 2018年12月18日

在 GitHub 查看
 (0 留言) (0 反應) (1 負責人)JavaScript (14,836 star) (1,283 fork)batch import
buggrammarshelp wantedopen for PR

描述

monaco-editor version: 0.15.6 Browser: Edge OS: Windows NT x64 10.0.17763 Note: Issue also affects VS Code

Steps reproducing the issue: F# tokenizes strings in block comments. Basically, Monaco is breaking the highlighting of code that uses strings within block comments. Here are some images:

This image is from The F# 4.1 Language Specification manual (section 3.2, pg. 23). Imgur

This is how Visual Studio IDE correctly interprets the styling: Imgur

This is how Monaco interpret the styling: Imgur

Comments used to test the highlighter:

(* Here's a code snippet: let s = "*)" *) let i = 1
(* """ *) let j = 2

貢獻者指南

技術棧
typescript
領域
frontenddeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TextMate grammarF# syntaxMonaco editor codebase
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
The issue is a bug in the F# syntax highlighting where strings inside block comments are incorrectly tokenized. The fix involves modifying the TextMate grammar for F# in the Monaco editor source (likely 'src/fsharp.ts' or similar). First, examine the existing grammar patterns to understand how block comments and strings are defined. Then, adjust the patterns to ensure that strings do not get tokenized when they appear inside block comments, as per the F# specification. Test with the provided examples: '(* Here's a code snippet: let s = "*)" *) let i = 1' and '(* """ *) let j = 2'. Check if the issue has been resolved in later versions or if there is an existing pull request.