Microsoft/TypeScript

JSX attributes should use double quote by default

Open

#50,541 建立於 2022年8月30日

在 GitHub 查看
 (0 留言) (3 反應) (0 負責人)TypeScript (48,455 star) (6,726 fork)batch import
Experience EnhancementHelp WantedSuggestion

描述

Like prettier default behavior: Although you set using single quotes in javascript, but jsx attributes still using double quotes.

prettier playgound

I think the reason is jsx isn't toatally javascript, it's also mark language. When deal with jsx attributes, we should using mark language quotes style.

In fact, react users may using the single quote or double quotes for javascript. But every users must use double quotes for jsx attributes.

Like https://github.com/microsoft/vscode/issues/143164#issuecomment-1042328896 comment, we may need a new setting for this.

Version: 1.71.0-insider (Universal)
Commit: 16faaf4eb07424d5d7dba7d12bffd64309c283f7
Date: 2022-08-29T15:28:34.899Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 21.6.0
Sandboxed: Yes

@mjbvz @nifte @rzhao271

https://user-images.githubusercontent.com/41773861/187392236-3e748945-9eb3-4ea9-84c4-eba094ac2159.mov

貢獻者指南

技術棧
typescriptjavascriptreact
領域
frontenddeveloper experiencetooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
TypeScript compiler basicsJSX parsing knowledgeConfiguration options
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the TypeScript language service's JSX formatting logic, likely in src/services/formatting/. Look for existing options for quote style in JavaScript vs JSX. Consider adding a new configuration option to enforce double quotes for JSX attributes, similar to Prettier's behavior. Check linked issue microsoft/vscode#143164 for additional context. Consult maintainers on preferred implementation approach.