Microsoft/TypeScript

`.call` selects the wrong overload for `String.prototype.replace`

Open

#29,789 建立於 2019年2月7日

在 GitHub 查看
 (3 留言) (2 反應) (0 負責人)TypeScript (48,455 star) (6,726 fork)batch import
BugDomain: lib.d.tsHelp Wanted

描述

TypeScript Version: v3.3.1 and v3.4.0-dev.20190206

Search Terms: call replace overload

Code

String.prototype.replace.call(
    'one string',
    /a/g,
    'two string', // this line errors
);

It's worth noting that this is in a JS file, not a TS file, but I'm using allowJs and checkJs.

Expected behavior: No error.

Actual behavior: errors with error TS2345: Argument of type '"two string"' is not assignable to parameter of type '(substring: string, ...args: any[]) => string'

Playground Link: http://www.typescriptlang.org/play/#src=String.prototype.replace.call(%0D%0A%20%20%20%20'one%20string'%2C%0D%0A%20%20%20%20%2Fa%2Fg%2C%0D%0A%20%20%20%20'two%20string'%2C%0D%0A)%3B but the error doesn't seem to show up there.

Related Issues: no

貢獻者指南

技術棧
typescript
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TypeScript overload resolutionJavaScript String.replaceTypeScript compiler internals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
Investigate the overload resolution for String.prototype.replace.call in the context of JavaScript files with checkJs enabled. The issue is that when calling .call with arguments, TypeScript selects the wrong overload (the one expecting a function instead of a string). Check the checker.ts file for the overload resolution logic, particularly for .call on functions. Also, verify if the issue is reproducible in newer versions of TypeScript.
`.call` selects the wrong overload for `String.prototype.replace` · Microsoft/TypeScript#29789 | Good First Issue