API: incorrect declarations in types.ts · Microsoft/TypeScript#24706

(5 留言) (12 反應) (0 負責人)TypeScript (48,455 star) (6,726 fork)batch import

Breaking ChangeHelp WantedInfrastructure

描述

The --strictNullChecks PR changed some declarations in types.ts to avoid frequent assertions in the compiler's code. Unfortunately these changes make it really unsafe for API users because they no longer contain the actually nullable types: https://github.com/Microsoft/TypeScript/pull/22088#discussion_r184149465 https://github.com/Microsoft/TypeScript/pull/22088#discussion_r184155027

ts.Node#parent is no longer optional (which is definitely wrong for SourceFile)
ts.Symbol#declarations and ts.Symbol.valueDeclaration are no longer optional, but can still be undefined
ts.Type#symbol is no longer optional, but I guess this comment is still up to date: // Symbol associated with type (if any)

These changes should either be reverted or replaced in the published declaration files. /cc @andy-ms @weswigham

技術棧: typescript
領域: api
議題類型: bug
難度: 4
預計時間: 1-2 days
活動狀態: stale
清晰度: clear
前置要求: TypeScript strictNullChecksTypeScript compiler internalsType declaration files (.d.ts)Git and GitHub workflow
新手友善度: 25
研究方向: Review the PR #22088 and the specific discussions referenced (discussion r184149465, discussion r184155027). Examine the current types.ts in the TypeScript compiler to identify the declarations for Node.parent, Symbol.declarations, Symbol.valueDeclaration, and Type.symbol. Determine whether to revert the changes or add proper optionality. Check for any follow up comments or maintainer guidance. Propose a fix that ensures type safety while maintaining API compatibility.