Microsoft/TypeScript

Assignments to global objects in Javascript should be global declarations

Open

#22,446 建立於 2018年3月9日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)TypeScript (48,455 star) (6,726 fork)batch import
BugDomain: JavaScriptEffort: ModerateExperience EnhancementHelp WantedRescheduled

描述

// @noEmit: true
// @allowJs: true
// @checkJs: true
// @Filename: a.js
global.x = 1
window.y = 2
this.z = 3

var n = x + y + z

Expected behavior: No error, and x, y and z are visible globally.

Actual behavior: Errors:

  1. Can't find name 'global'
  2. 'Window' has no property 'y'
  3. Cannot find name 'x', 'y' or 'z'

Ideally, global should only be visible when targetting node and window should only be visible when targetting the browser. It's not a requirement, though.

貢獻者指南

技術棧
typescriptjavascript
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TypeScript basicsGlobal scope concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate how the TypeScript compiler handles global assignments in .js files with checkJs enabled. Examine the type checker (src/compiler/checker.ts) to understand why 'global' is not recognized as a global object and why assignments to 'window' and 'this' are not treated as global declarations. Look at existing tests in tests/cases/... The issue provides a minimal reproduction; the fix likely involves updating the handling of global property assignments in JavaScript mode.
Assignments to global objects in Javascript should be global declarations · Microsoft/TypeScript#22446 | Good First Issue