Microsoft/TypeScript

Line break in module declaration causes compile time error

Open

#11,167 建立於 2016年9月27日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)TypeScript (48,455 star) (6,726 fork)batch import
BugDomain: ParserHelp Wanted

描述

TypeScript Version: 2.0.3

A line break in the declaration of a module causes a compile time error. This could either be that the language specification isn't clear that this is illegal or a bug.

Code

// Example declaration with line break
declare module 
     my.very.long.name.foo.bar.baz.able.baker {}

Expected behavior: I don't see anything in the language specification that would make this a compile time error, so I would expect the statement to work as if declaration was all on one line, ie:

// Example declaration with line break
declare module my.very.long.name.foo.bar.baz.able.baker {}

Actual behavior:

A compile time error, in particular: (1, 9): error TS1005: ';' expected.

貢獻者指南

技術棧
typescript
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic knowledge of TypeScript compiler parsing
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the TypeScript scanner (src/compiler/scanner.ts) or parser (src/compiler/parser.ts) to understand how line breaks are handled between 'declare' and 'module'. Compare with other declarations like 'function' or 'class'. Look for any token separation logic that might treat newline as a statement separator. The fix likely involves modifying the scanner to allow line breaks in module name tokens.