Microsoft/TypeScript

Formatter fails to format uglified files

Open

#10,126 建立於 2016年8月4日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)TypeScript (48,455 star) (6,726 fork)batch import
Domain: FormatterHelp WantedSuggestionVS Code Tracked

描述

TypeScript Version: 1.8.10

I use vscode from the Command Palette to format a javascript file uglified by uglify-js, but it failed. It not format code correctly, and only format partially.

source file 2016-07-12 4 47 08

sublime jsFormat formated 2016-07-12 4 47 29

vscode formated 2016-07-12 4 47 45

You see, It seems like, vscode only add some spaces around brackets, letters, commas etc.

See https://github.com/Microsoft/vscode/issues/8914#issuecomment-231978337 and the discussion below for more details. The provided traces clearly show that the tsserver only returns white space (" ") changes. No insertion of new lines.

貢獻者指南

技術棧
typescriptjavascript
領域
developer experiencetooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Basic understanding of TypeScript's formatter internals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
10
研究方向
Investigate the TypeScript formatter source code, likely in src/services/formatting/, to understand how it handles whitespace and line breaks. The issue indicates that the formatter only inserts spaces but not new lines for minified code. Reproduce with a uglified JS file and trace the formatting output. Look for relevant tests or linked issues like https://github.com/Microsoft/vscode/issues/8914 for additional context.