Meteor-Community-Packages/meteor-roles

Add isInRole to JS API as well

Open

#56 建立於 2014年9月19日

在 GitHub 查看
 (17 留言) (0 反應) (0 負責人)JavaScript (919 star) (161 fork)batch import
enhancementgood first issuehelp wanted

描述

Something you frequently do in the application, is check if the current user is allowed to access something. As there currently is no shorthand for this in the Javascript API, you have to do something like:

if ( Roles.userIsInRole( Meteor.userId(), 'permission' ) )
    // ...

I noticed the UI helper offers a beautiful shortand syntax for this, using the currently logged in user. I think it would make a lot of sense to add this to the API as well, so that one can simply do:

if ( Roles.isInRole( 'permission' ) )
    // ...

or even better:

if ( Roles.has( 'permission' ) )
    // ...

貢獻者指南

技術棧
javascript
領域
authenticationauthorization
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
understanding of Meteor roles APIbasic JavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The issue requests a shorthand method `Roles.isInRole('permission')` or `Roles.has('permission')` in the JS API, similar to the existing UI helper. To implement, look at the UI helper code in roles client.js (lines 28-35) and the current Roles.userIsInRole function. Add a new method that calls Roles.userIsInRole with the current user ID obtained from Meteor.userId(). Ensure the method is exported and documented.