Meteor-Community-Packages/meteor-roles

Internal function _getInheritedRoleNames() should return role object

Open

#304 建立於 2019年12月10日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (919 star) (161 fork)batch import
enhancementgood first issue

描述

https://github.com/Meteor-Community-Packages/meteor-roles/blob/32c230ded9cb92b27a3485d143cabf2732fef186/roles/roles_common.js#L543-L557

The function _getInheritedRoleNames() is currently used to construct the array inheritedRoles on a role-assignment, where it only takes over the parameter _id. If you have data stored on the role, wouldn't it be better to have it copied along?

If one of these parameter changes, the programmer extending this package would then be responsible for also keeping this data updated there. If he doesn't need it there, he can extend this package wrapping this function to remove the additional properties.

貢獻者指南

技術棧
javascriptnodejsmongodb
領域
authorization
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptMeteor
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Examine the ` getInheritedRoleNames()` function in `roles/roles common.js` (lines 543–557). Understand how it currently returns only role names and how the `inheritedRoles` array is constructed. Consider modifying the function to return the full role object so that additional properties are preserved. Evaluate the impact on callers and ensure backward compatibility or provide an option.