MetaMask/metamask-extension

Replace deprecated TextField component with TextField from the component-library

Open

#20,483 建立於 2023年8月16日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)JavaScript (11,014 star) (4,848 fork)batch import
good first issueteam-design-system

描述

Description

Currently, the extension is using an outdated TextField component, which needs to be replaced with the new TextField component.

This is a massive undertaking by itself and creating a single PR would be too large. Smaller PRs can be submitted against this issue to ensure easier review and gradual improvements. It also means that this issue will not be assigned to a single engineer

Technical Details

  • Replace instances of TextField component (ui/components/ui/text-field/text-field.component.js) with TextField component (ui/components/component-library/text-field/text-field.js)
  • Component APIs are slightly different so ensure all props have been migrated appropriately
  • Ensure there are no visual or functional regressions

Acceptance Criteria

  • Instances of TextField component are completely replaced with the new TextField component
  • The component APIs are updated to reflect the changes in the new `TextField`` component and there is no functional changes or visual regression
  • Each Pull Request (PR) should include no more than 3 files
  • The code changes should pass Jest tests, linting, and Storybook without any errors.
  • The PR must include before and after screenshots of the UI to ensure there are no visual regressions.

If the acceptance criteria is not met, PRs may be closed.

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with running the extension locally, have knowledge of React, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in the extension

貢獻者指南