ManimCommunity/manim

Lagging animations with updaters and self.add

Open

#1,648 建立於 2021年6月7日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)Python (1,378 fork)batch import
help wantedissue:bug

倉庫指標

Star
 (17,820 star)
PR 合併指標
 (平均合併 90天 10小時) (30 天內合併 31 個 PR)

描述

Description of bug / unexpected behavior

Animations behave differently depending on the way the mobject was added to the scene. If I use self.play(Create(mobj)) there is no lag, if I use self.add(mobj) the animation lags in certain cases.

Expected behavior

IMHO there should be no difference between the two cases. Also, if using self.add is discouraged for objects that have updaters, we might consider printing a warning.

How to reproduce the issue

See the following code:

from manim import *

class Test(Scene):
    def construct(self):
        tracker = ValueTracker(-3)
        rect = Rectangle().set_x(tracker.get_value())
        label = Text("x")
        rect.add_updater(lambda m: m.set_x(tracker.get_value()))
        label.add_updater(lambda m: m.move_to(rect.get_center()))
        self.add(rect,label)
        self.play(tracker.animate.set_value(4))
        self.wait()
        self.play(FadeIn(rect))
        self.play(tracker.animate.set_value(-4))
        self.wait()
from manim import *

class Test(Scene):
    def construct(self):
        tracker = ValueTracker(-3)
        rect = Rectangle().set_x(tracker.get_value())
        label = Text("x")
        rect.add_updater(lambda m: m.set_x(tracker.get_value()))
        label.add_updater(lambda m: m.move_to(rect.get_center()))
        self.add(rect,label)
        self.play(tracker.animate.set_value(4))
        self.wait()
        #self.play(FadeIn(rect))
        self.add(rect)
        self.play(tracker.animate.set_value(-4))
        self.wait()

Additional media files

https://user-images.githubusercontent.com/52650214/120992430-e36a4300-c782-11eb-80e4-d228dae55858.mp4

貢獻者指南