Lightning-AI/pytorch-lightning

Refactor LearningRateMonitor

Open

#17,613 建立於 2023年5月11日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Python (3,233 fork)batch import
callback: lr monitorfeaturehelp wantedrefactor

倉庫指標

Star
 (26,687 star)
PR 合併指標
 (平均合併 9天 15小時) (30 天內合併 3 個 PR)

描述

Outline & Motivation

  • self.last_momentum_values does not seem needed, but I may be overlooking something.
  • Instead of returning the name with -momentum suffix when logging betas, just log it with -beta suffix.
  • If logging betas, log all of them. The name could therefore be -beta0, -beta1 in the case of Adam.
  • Change the current logging names, e.g., lr-Adam to optimizer-Adam-lr and lr-Adam-momentum to optimizer-Adam-momentum (it doesn't have momentum this is just for demonstration, it would actually be optimizer-Adam-beta0, optimizer-Adam-beta1).
  • remove the log_momentum argument as it can be inferred automatically.

Pitch

Happy to open a PR with these changes.

Additional context

No response

cc @borda @justusschock @awaelchli

貢獻者指南