Lightning-AI/pytorch-lightning

BUG when Trainer.test() with deepspeed stage 3

Open

#14,090 建立於 2022年8月8日

在 GitHub 查看
 (2 留言) (2 反應) (0 負責人)Python (3,233 fork)batch import
bughelp wantedrepro neededstrategy: deepspeed

倉庫指標

Star
 (26,687 star)
PR 合併指標
 (平均合併 9天 15小時) (30 天內合併 3 個 PR)

描述

🐛 Bug

Hi, I meet some bugs when I combine lightning with deepspeed follow https://pytorch-lightning.readthedocs.io/en/latest/common/trainer.html#trainer-class-api.

I find that:

  • Trainer.fit() is compatible well with deepspeed stage 2 and 3 .
  • Trainer.test() is compatible with deepspeed stage 2.
  • There is some bugs when combine Trainer.test() with deepspeed stage 3:

When initialize DeepSpeedStrategy with deepspeed config and then test, I will encounter this bug, I have tried to change the config, but this bug is exsited whatever.

image

When initialize DeepSpeedStrategy with lightning args, I will encounter two problems, the generate speed is too slow (I used huggingface transformers and their generate() method) than the deepspeed inference scripts in https://www.deepspeed.ai/tutorials/inference-tutorial/. In addition, I also meet a bug called index of range because of self.__step of deepspeed engine.

Hope for better compatibility between lightning and deepspeed !

cc @awaelchli @rohitgr7 @akihironitta

貢獻者指南