Kovah/LinkAce

Add support for password files

Open

#199 建立於 2020年12月31日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)PHP (1,761 star) (111 fork)batch import
EnhancementHelp wanted

描述

Is your feature request related to a problem? Please describe. Specifying passwords in environment variables is not always the best available approach. Docker swarm, for example, has support for the concepts of secrets. These are in-memory files mounted in containers under /var/run. To support the use of these secrets, an app must support reading passwords from files.

Describe the solution you'd like Add support for DB_PASSWORD_FILE and DB_REDIS_PASSWORD_FILE environment variables that, if set, will read the passwords from the specified path instead of the regular environment variables.

Describe alternatives you've considered Using the .env file, but it doesn't solve the issue as Docker's secret management can't be used with it.

Additional context None.

貢獻者指南

技術棧
無
領域
backendsecurity
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
knowledge of PHP environment variable handlingfamiliarity with Docker secrets
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate how environment variables like DB PASSWORD are currently read in the codebase, likely in config/database.php or similar. Then implement logic to check for DB PASSWORD FILE and read the file contents if set. Ensure to handle file not found errors gracefully. Review the two existing comments in the issue for any additional clarification.