Knockout-Contrib/Knockout-Validation

Consistent coding style suggestions

Open

#488 建立於 2014年12月23日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)JavaScript (1,024 star) (394 fork)batch import
help wanted

描述

I'm considering making some changes which should help us have a more maintainable and uniform source code. Here's what I have in mind:

  • make all directories lowercase (Dist -> dist, Src -> src)
  • ensure consistent coding style using http://editorconfig.org/
  • use spaces instead of tabs - e.g. gruntfile looks really bad when open in Github
  • add more JSHint rules

Although it's not critical to implement this right now, I want to have some feedback before going further. I would prefer to have this pushed to v2 release since we have a lot of changes since last release and it would be a good time for it - v2 release notes here.

Feel free to share your ideas to make this project better.

貢獻者指南

技術棧
javascriptnodejs
領域
developer experiencetooling
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Basic knowledge of Knockout JSFamiliarity with grunt
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
The issue proposes several coding style improvements like renaming directories to lowercase, adding EditorConfig, enforcing spaces instead of tabs, and adding JSHint rules. Check the comments for any feedback from maintainers or contributors. Since the issue is from 2014 and no linked PR exists, it may be stale. Investigate if the maintainers still plan to implement these changes for v2 or if they have been addressed elsewhere.