JuliaPlots/Plots.jl

[FR] `append!` cannot accept collections (as would be expected from the name)

Open

#4,825 建立於 2023年9月19日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Julia (1,943 star) (381 fork)batch import
enhancementgood first issue

描述

The signature of the append! method through which all others pass accepts only Real..., meaning it cannot actually add multiple datapoints to a series. It is my understanding that in Julia, append! is generally meant to be the bulk equivalent of push!, but because of this signature, append! for plots is just a less flexible version of push!.

The problematic method definition: https://github.com/JuliaPlots/Plots.jl/blob/7cd27c470e10d8364ab935935eb58a97eae55ce3/src/utils.jl#L810C1-L810C90 image

If I understand correctly, just making the type of args less restrictive, to include vectors, would fix this. The signature of the previous method should probably also be changed for consistency but that would be a breaking change.

貢獻者指南

技術棧
無
領域
data
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Julia programming basicsUnderstanding of method signaturesFamiliarity with Plots.jl
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The issue points to a specific method definition in src/utils.jl at line 810, where the signature restricts args to Real. The fix involves changing the type to accept collections (e.g., Vector). However, this could break other callers, so examine all uses of the method. Also check the previous method definition for consistency. The maintainer may have opinions on the best approach.