JuliaLang/julia

cpp namespace pollution in julia.h

Open

#10,682 建立於 2015年3月30日

在 GitHub 查看
 (6 留言) (0 反應) (0 負責人)Julia (48,709 star) (5,773 fork)batch import
embeddinghelp wanted

描述

The julia.h file #defines a bunch of symbols that could easily conflict with other header files if someone is embedding Julia: NWORDS, NORETURN, DLLEXPORT, MAX_ALIGN, STORE_ARRAY_LEN, ARRAY_INLINE_NBYTES, ENABLE_INFERENCE, COPY_STACKS, STDCALL, NBITS ... (tons of stuff via libsupport.h)

It seems like it would be better to

  • qualify all preprocessor symbols with JL_ in the julia.h file
  • include libsupport.h only in julia_internal.h.

貢獻者指南

技術棧
ccpp
領域
backendapi
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
understanding of C preprocessorknowledge of Julia embedding API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
The issue is to rename all preprocessor symbols in julia.h with the JL prefix to avoid namespace conflicts, and to move the inclusion of libsupport.h to julia internal.h. The main files involved are julia.h and libsupport.h. A good starting point is to list all symbols defined in julia.h and libsupport.h that do not have the JL prefix, then rename them and update all usages across the codebase. Check if there are any existing discussions or PRs linked to this issue; currently none. Ensure that the move of libsupport.h does not break other files that rely on its definitions.